Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA: Support profiles associated with authorizations #7956

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Jan 17, 2025

Add "certificateProfileName" to the model used to insert new authz2 rows and to the list of column names read when retrieving rows from the authz2 table. Add support for this column to the functions which convert to and from authz2 model types.

Add support for the profile field to core types so that it can be returned by the SA.

Fixes #7955


Warning

Do not merge until IN-10973 is complete

Base automatically changed from authz-profile-col to main January 21, 2025 17:38
@aarongable aarongable force-pushed the authz-profile branch 2 times, most recently from 0ca78f0 to a620455 Compare January 21, 2025 23:26
@aarongable aarongable marked this pull request as ready for review January 21, 2025 23:47
@aarongable aarongable requested a review from a team as a code owner January 21, 2025 23:47
@aarongable aarongable requested a review from jprenken January 21, 2025 23:47
Copy link
Contributor

@aarongable, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@aarongable aarongable changed the title Support profiles associated with authorizations SA: Support profiles associated with authorizations Jan 21, 2025
@letsencrypt letsencrypt deleted a comment from github-actions bot Jan 21, 2025
jprenken
jprenken previously approved these changes Jan 22, 2025
@jprenken jprenken requested review from a team and jsha and removed request for a team January 22, 2025 00:02
jsha
jsha previously approved these changes Jan 22, 2025
sa/sa_test.go Outdated Show resolved Hide resolved
@aarongable aarongable dismissed stale reviews from jsha and jprenken via af8cbe0 January 22, 2025 17:44
@aarongable aarongable requested review from jprenken and jsha January 22, 2025 17:46
jsha
jsha previously approved these changes Jan 22, 2025
jprenken
jprenken previously approved these changes Jan 22, 2025
@aarongable aarongable dismissed stale reviews from jprenken and jsha via 62acf88 January 27, 2025 22:32
@aarongable aarongable requested a review from jprenken January 27, 2025 22:32
@aarongable aarongable requested a review from jsha January 27, 2025 22:32
@aarongable aarongable merged commit 86ab2ed into main Jan 27, 2025
14 checks passed
@aarongable aarongable deleted the authz-profile branch January 27, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA: allow a profile name to be stored alongside an authz
3 participants