Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAA: Handle non-empty RRSets correctly during wildcard checking #8033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aarongable
Copy link
Contributor

When checking CAA, issuance is allowed if the relevant RRSet (as defined in RFC 8659, Section 3) does not contain any records of the right Property kind (issue or issuewild) for the kind of checking being attempted. Previously, we correctly detected that a non-wildcard issuance attempt could short-circuit our validation logic if no issue records are present. However, we did not do a similar short-circuit for wildcard issuance attempts when no issue records and no issuewild records are present.

Add a test which demonstrates that a nearly-empty RRSet accidentally forbade issuance of wildcard certs. Update our logic to perform the "no relevant records" check slightly later, so that it catches both the wildcard and non-wildcard cases, causing the new test to pass.

Fixes #8032

@aarongable aarongable marked this pull request as ready for review February 28, 2025 23:17
@aarongable aarongable requested a review from a team as a code owner February 28, 2025 23:17
@aarongable aarongable requested a review from jprenken February 28, 2025 23:17
@jprenken jprenken requested review from a team and jsha and removed request for a team February 28, 2025 23:53
@verne-work
Copy link

thanks everyone !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-empty CAA RRSet for Wildcard domain accidentally forbids issuance
3 participants