Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix violations of gosec in the golangci.yml lints #133

Open
andygabby opened this issue Apr 3, 2023 · 0 comments
Open

Fix violations of gosec in the golangci.yml lints #133

andygabby opened this issue Apr 3, 2023 · 0 comments

Comments

@andygabby
Copy link
Member

andygabby commented Apr 3, 2023

PR #128 introduces some gosec lint exclusion.

We should research and fix the violations of these rules if possible. If the exclusion can't or won't be fixed then add lint exclusion text inline with each violation instead of a global exclude.

.golangci.yaml

  gosec:
    excludes:
      # TODO(#133): Identify, fix, and remove violations of most of these rules
      - G112 # Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)
      - G404 # Use of weak random number generator (math/rand instead of crypto/rand)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant