Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace black and flake8 with ruff #75

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 29, 2024

Fixes #70

After this ruff lint PR is merged we can have a followup PR to enable ruff format in pre-commit. We should first decide if we want to keep line-length at 99 or the default of 88.

@jcjones
Copy link
Collaborator

jcjones commented Feb 29, 2024

I'm fine going to 88, but lots of comments need to be adjusted:

partitionmanager/cli.py:410:89: E501 Line too long (96 > 88)
partitionmanager/cli_test.py:228:89: E501 Line too long (94 > 88)
partitionmanager/cli_test.py:231:89: E501 Line too long (94 > 88)
partitionmanager/cli_test.py:534:89: E501 Line too long (94 > 88)
partitionmanager/cli_test.py:539:89: E501 Line too long (94 > 88)
partitionmanager/cli_test.py:586:89: E501 Line too long (91 > 88)
partitionmanager/dropper.py:95:89: E501 Line too long (90 > 88)
partitionmanager/dropper_test.py:233:89: E501 Line too long (98 > 88)
partitionmanager/migrate.py:174:89: E501 Line too long (96 > 88)
partitionmanager/migrate.py:278:89: E501 Line too long (94 > 88)
partitionmanager/migrate_test.py:134:89: E501 Line too long (92 > 88)
partitionmanager/migrate_test.py:138:89: E501 Line too long (92 > 88)
partitionmanager/migrate_test.py:143:89: E501 Line too long (92 > 88)
partitionmanager/table_append_partition.py:88:89: E501 Line too long (91 > 88)
partitionmanager/table_append_partition.py:131:89: E501 Line too long (97 > 88)
partitionmanager/table_append_partition.py:244:89: E501 Line too long (91 > 88)
partitionmanager/table_append_partition.py:600:89: E501 Line too long (89 > 88)
partitionmanager/table_append_partition.py:700:89: E501 Line too long (94 > 88)
partitionmanager/types.py:344:89: E501 Line too long (98 > 88)

I like ruff though, this is great.

We can move to 88 and resolve the line lengths at the same time as we add --check to the ruff format; I'll open a follow-on.

@jcjones jcjones merged commit 57ef9fe into letsencrypt:main Feb 29, 2024
2 checks passed
@cclauss cclauss deleted the ruff branch February 29, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to ruff
2 participants