Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for num.rpz.action #70

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Add metric for num.rpz.action #70

merged 3 commits into from
Jan 8, 2024

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented Jan 4, 2024

Enables rpz support in the example unbound config and gathering a metric for each triggered rpz action.

$ curl -s localhost:9167/metrics | grep rpz
# HELP unbound_rpz_action_count Total number of triggered Response Policy Zone actions, by action.
# TYPE unbound_rpz_action_count counter
unbound_rpz_action_count{type="nxdomain"} 1

Fixes #69

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e9c7ff) 5.23% compared to head (79ea4be) 5.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #70   +/-   ##
=====================================
  Coverage   5.23%   5.23%           
=====================================
  Files          1       1           
  Lines        191     191           
=====================================
  Hits          10      10           
  Misses       181     181           
Flag Coverage Δ
unbound_exporter_tests 5.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pgporada pgporada requested review from a team and beautifulentropy and removed request for a team January 4, 2024 17:25
@raunz
Copy link

raunz commented Jan 4, 2024

👍 Looks great.

droplist.zone Outdated Show resolved Hide resolved
@pgporada pgporada requested review from jsha and jprenken January 4, 2024 19:04
@pgporada pgporada merged commit e284f50 into main Jan 8, 2024
5 checks passed
@pgporada pgporada deleted the scrape-rpz-action-metric branch January 8, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] rpz extended statistic support
6 participants