improvements to data types implementation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2014 14:02
add tests and document
| @@ -126,39 +127,42 @@ function levelgraphJSONLD(db, jsonldOpts) { | |||
| }; | |||
|
|
|||
| // http://json-ld.org/spec/latest/json-ld-api/#data-round-tripping | |||
| var coerceLiteral = function(literal) { | |||
| var getCoercedObject = function(object) { | |||
There was a problem hiding this comment.
For optimization it is much better to have named functions instead of anonymous functions insider a variable.
I also do a lot of this mistake, but I try to fix it wherever I look.
|
As for the rest, 👍. Merge when you prefer. |
elf-pavlik
pushed a commit
that referenced
this pull request
Jan 28, 2014
improvements to data types implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #14 with