#15: Distinguish between immutable Boolean rules and Numeric rules (w…

…ith limit read support)

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/AverageExecutionTimeRule.java

@@ -6,7 +6,7 @@
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.HealthStatus;
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.JmxHelper;
 
-public class AverageExecutionTimeRule implements Rule<Long> {
+public class AverageExecutionTimeRule implements NumericRule<Long> {
 
   private final long limit;
 
@@ -18,6 +18,11 @@ public AverageExecutionTimeRule(long limit) {
   public String getDescription() {
     return "Average execution time";
   }
+
+  @Override
+  public Long getLimit() {
+    return limit;
+  }
 
   @Override
   public EvaluationResult<Long> evaluate(MBeanServerConnection mbsc) {

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/ImmutableBooleanRule.java

@@ -0,0 +1,7 @@
+package org.levigo.jadice.server.converterclient.gui.clusterhealth.rule;
+
+public interface ImmutableBooleanRule extends Rule<Boolean> {
+
+  boolean getExpectedValue();
+
+}

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/NumericRule.java

@@ -0,0 +1,7 @@
+package org.levigo.jadice.server.converterclient.gui.clusterhealth.rule;
+
+public interface NumericRule<T extends Number> extends Rule<T>  {
+
+  T getLimit();
+
+}

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/RecentAverageExecutionTimeRule.java

@@ -6,7 +6,7 @@
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.HealthStatus;
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.JmxHelper;
 
-public class RecentAverageExecutionTimeRule implements Rule<Long> {
+public class RecentAverageExecutionTimeRule implements NumericRule<Long> {
 
   private final long limit;
 
@@ -18,6 +18,11 @@ public RecentAverageExecutionTimeRule(long limit) {
   public String getDescription() {
     return "Average execution time";
   }
+
+  @Override
+  public Long getLimit() {
+    return limit;
+  }
 
   @Override
   public EvaluationResult<Long> evaluate(MBeanServerConnection mbsc) {

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/RecentEfficiencyRule.java

@@ -6,7 +6,7 @@
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.HealthStatus;
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.JmxHelper;
 
-public class RecentEfficiencyRule implements Rule<Float> {
+public class RecentEfficiencyRule implements NumericRule<Float> {
 
   private final float limit;
 
@@ -18,6 +18,11 @@ public RecentEfficiencyRule(float limit) {
   public String getDescription() {
     return "Recent efficiency";
   }
+
+  @Override
+  public Float getLimit() {
+    return limit;
+  }
 
   @Override
   public EvaluationResult<Float> evaluate(MBeanServerConnection mbsc) {

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/RecentFailureRateRule.java

@@ -6,7 +6,7 @@
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.HealthStatus;
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.JmxHelper;
 
-public class RecentFailureRateRule implements Rule<Float> {
+public class RecentFailureRateRule implements NumericRule<Float> {
 
   private final float limit;
 
@@ -18,6 +18,11 @@ public RecentFailureRateRule(float limit) {
   public String getDescription() {
     return "Recent failure rate";
   }
+
+  @Override
+  public Float getLimit() {
+    return limit;
+  }
 
   @Override
   public EvaluationResult<Float> evaluate(MBeanServerConnection mbsc) {

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/Rule.java

@@ -7,4 +7,5 @@ public interface Rule<T> {
   String getDescription();
 
   EvaluationResult<T> evaluate(MBeanServerConnection mbsc);
-}
+
+}

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/ServerRunningRule.java

@@ -6,12 +6,17 @@
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.HealthStatus;
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.JmxHelper;
 
-public class ServerRunningRule implements Rule<Boolean> {
+public class ServerRunningRule implements ImmutableBooleanRule {
 
   @Override
   public String getDescription() {
     return "Instance is running";
   }
+
+  @Override
+  public boolean getExpectedValue() {
+    return true;
+  }
 
   @Override
   public EvaluationResult<Boolean> evaluate(MBeanServerConnection mbsc)  {

src/main/java/org/levigo/jadice/server/converterclient/gui/clusterhealth/rule/TotalFailureRateRule.java

@@ -6,7 +6,7 @@
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.HealthStatus;
 import org.levigo.jadice.server.converterclient.gui.clusterhealth.JmxHelper;
 
-public class TotalFailureRateRule implements Rule<Float> {
+public class TotalFailureRateRule implements NumericRule<Float> {
 
   private final float limit;
 
@@ -18,6 +18,11 @@ public TotalFailureRateRule(float limit) {
   public String getDescription() {
     return "Total failure rate";
   }
+
+  @Override
+  public Float getLimit() {
+    return limit;
+  }
 
   @Override
   public EvaluationResult<Float> evaluate(MBeanServerConnection mbsc) {