feat: use jsdom as test environment #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levino
force-pushed
the
feature/test-with-jsdom
branch
from
ba94f7b
to
ca36099
Compare
levino
commented
Dec 8, 2022
Comment on lines
-17
to
-18
| - name: Test | ||
| run: npm run test:ci |
There was a problem hiding this comment.
These changes are irrelevant to firebase/firebase-js-sdk#6747
levino
force-pushed
the
feature/test-with-jsdom
branch
from
ca36099
to
e6732d2
Compare
levino
force-pushed
the
feature/test-with-jsdom
branch
from
b8e913f
to
bbca0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce firebase/firebase-js-sdk#6747