Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MakeConst to simplify AstParser #9

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Remove MakeConst to simplify AstParser #9

merged 1 commit into from
Sep 30, 2023

Conversation

edubrovski
Copy link
Contributor

No description provided.

@edubrovski edubrovski force-pushed the edubrovsky/refactor-2 branch 2 times, most recently from b0d2f41 to 04283fa Compare September 30, 2023 15:04
@edubrovski edubrovski changed the title Simplify code of AstParser Remove MakeConst to simplify code of AstParser Sep 30, 2023
@edubrovski edubrovski changed the title Remove MakeConst to simplify code of AstParser Remove MakeConst to simplify AstParser Sep 30, 2023
@edubrovski edubrovski force-pushed the edubrovsky/refactor-2 branch from 04283fa to aa4c51c Compare September 30, 2023 15:15
@edubrovski edubrovski force-pushed the edubrovsky/refactor-2 branch from aa4c51c to 17e650c Compare September 30, 2023 15:16
desavitsky
desavitsky approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@desavitsky desavitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edubrovski edubrovski merged commit 4e6e873 into main Sep 30, 2023
4 checks passed
@edubrovski edubrovski deleted the edubrovsky/refactor-2 branch September 30, 2023 15:57
@danslapman danslapman added the enhancement New feature or request label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desavitsky desavitsky desavitsky approved these changes

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@Assassin4791 Assassin4791 Awaiting requested review from Assassin4791 Assassin4791 is a code owner

@InversionSpaces InversionSpaces Awaiting requested review from InversionSpaces InversionSpaces is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edubrovski @desavitsky @danslapman