Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom repository prefix for private registry #257

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gannaraputeja
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@gannaraputeja gannaraputeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes.

@@ -24,6 +24,7 @@ trap "exit" INT

region="us-west-2"
registry="your.registry"
repositoryPrefix="your.repository-prefix"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be optional.

imagePullSecrets:
- name: ecr-auth
busyboxImage: <your.repository-prefix>/busybox

rabbitmq:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this as separate values.yaml file so that they can use it only when they want to override the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants