Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support for C++ target #2322

Merged
merged 14 commits into from
Jun 19, 2024
Merged

Docker support for C++ target #2322

merged 14 commits into from
Jun 19, 2024

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Jun 17, 2024

No description provided.

@lhstrh lhstrh added the feature New feature label Jun 17, 2024
@cmnrd cmnrd added this to the 0.8.0 milestone Jun 17, 2024
@lhstrh lhstrh requested a review from cmnrd June 18, 2024 05:29
@lhstrh
Copy link
Member Author

lhstrh commented Jun 18, 2024

@oowekyala are you interested in pulling together the same ability for Rust?

@lhstrh lhstrh mentioned this pull request Jun 18, 2024
13 tasks
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start, but unfortunately, this does not work on my machine. I get:

WARN[0000] a network with name lf exists but was not created for project "helloworldcontainerized".
Set `external: true` to use an existing network
[+] Running 1/0
 ✔ Container HelloWorldContainerized  Created                                                                                                                                                                       0.0s
Attaching to HelloWorldContainerized
HelloWorldContainerized  | Error loading shared library libreactor-cpp-default.so.1: No such file or directory (needed by ./bin/HelloWorldContainerized)
HelloWorldContainerized  | Error loading shared library libexecinfo.so.1: No such file or directory (needed by ./bin/HelloWorldContainerized)
HelloWorldContainerized  | Error loading shared library libstdc++.so.6: No such file or directory (needed by ./bin/HelloWorldContainerized)
HelloWorldContainerized  | Error loading shared library libgcc_s.so.1: No such file or directory (needed by ./bin/HelloWorldContainerized)
HelloWorldContainerized  | Error relocating ./bin/HelloWorldContainerized: _ZN7reactor14ReactorElementC2ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEENS0_4TypeEPNS_7ReactorE: symbol not found
HelloWorldContainerized  | Error relocating ./bin/HelloWorldContainerized: _ZSt9use_facetISt5ctypeIcEERKT_RKSt6locale: symbol not found
HelloWorldContainerized  | Error relocating ./bin/HelloWorldContainerized: __cxa_free_exception: symbol not found
HelloWorldContainerized  | Error relocating ./bin/HelloWorldContainerized: __cxa_begin_catch: symbol not found
HelloWorldContainerized  | Error relocating ./bin/HelloWorldContainerized: _ZNKSt9basic_iosIcSt11char_traitsIcEE4failEv: symbol not found
...

Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a quite significant overhaul. Most importantly, the docker generators are now inner classes of the platform-specific generators (CppStandalonGenerator and CppRos2Generator).

Docker generation for ROS2 works now, too. This is particularly useful as it allows building and running ROS nodes without a ROS installation.

Copy link
Member Author

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmnrd, this looks very nice!!

@lhstrh lhstrh merged commit 6f13f01 into pre-build-cmd Jun 19, 2024
25 of 26 checks passed
@lhstrh lhstrh deleted the docker-cpp branch June 19, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants