Remove ioctl from TcpIpChannel #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LasseRosenow
changed the title
tanneberger
approved these changes
Oct 14, 2024
erlingrj
reviewed
Oct 15, 2024
Comment on lines
+152
to
+153
| int select_result = select(socket + 1, &read_fds, NULL, NULL, &timeout); | ||
| if (select_result <= 0) { |
There was a problem hiding this comment.
Do we actually need to check how much data is there before we read? Since this is running in a separate thread, we want it to block on recv and return with as much data is available. What is gained from checking how much data is there before the read?
(I know that this was there before your edits, and perhaps @tanneberger can answer better?)
|
Great to see that you are already contributing code Lasse. I think the CI ight fail because the PR is coming from your fork. Could you try just filing it from a branch in this repo. I think you have the necessary access. |
|
It seems you are correct, I will close this in favor of #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the TcpIpChannel implementation in the following way
ioctl.h=>sys/select.hcloseinstead ofshutdown, which is not available inRIOTThe rationale behind this is to improve compatibility with platforms such as
zephyrorRIOTwhich don't have full POSIX support.This PR is a draft because I didn't have time to test it yet. There might be implementation bugs.
(I had some problems with compiling the example applications in examples/posix)