chore: remove warning

lfglabs-dev · Jan 4, 2024 · 577ab88 · 577ab88
1 parent fbd6ff8
commit 577ab88
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 23 deletions.
diff --git a/src/endpoints/leaderboard/get_ranking.rs b/src/endpoints/leaderboard/get_ranking.rs
@@ -238,19 +238,23 @@ pub async fn handler(
     State(state): State<Arc<AppState>>,
     Query(query): Query<GetCompletedQuestsQuery>,
 ) -> impl IntoResponse {
-    let mut time_gap = 0;
-
-    // check value of duration and set time_gap accordingly
-    if query.duration == "week" {
-        time_gap = get_timestamp_from_days(7);
-    } else if query.duration == "month" {
-        time_gap = get_timestamp_from_days(30);
-    } else if query.duration == "all" {
-        time_gap = 0;
-    } else {
-        return get_error("Invalid duration".to_string());
-    }
 
+
+    // check value of duration and set time_gap accordingly using match and respective timestamp
+    let time_gap = match query.duration.as_str() {
+        "week" => {
+            get_timestamp_from_days(7)
+        }
+        "month" => {
+            get_timestamp_from_days(30)
+        }
+        "all" => {
+            0
+        }
+        _ => {
+            return get_error("Invalid duration".to_string());
+        }
+    };
     // get collection
     let users_collection = state.db.collection::<Document>("leaderboard_table");
 

diff --git a/src/endpoints/leaderboard/get_static_info.rs b/src/endpoints/leaderboard/get_static_info.rs
@@ -39,18 +39,22 @@ pub async fn handler(
 ) -> impl IntoResponse {
     let addr: String = query.addr.to_string();
     let collection = state.db.collection::<Document>("leaderboard_table");
-    let mut time_gap = 0;
 
-    // check value of duration and set time_gap accordingly
-    if query.duration == "week" {
-        time_gap = get_timestamp_from_days(7);
-    } else if query.duration == "month" {
-        time_gap = get_timestamp_from_days(30);
-    } else if query.duration == "all" {
-        time_gap = 0;
-    } else {
-        return get_error("Invalid duration".to_string());
-    }
+    // check value of duration and set time_gap accordingly using match and respective timestamp
+    let time_gap = match query.duration.as_str() {
+        "week" => {
+            get_timestamp_from_days(7)
+        }
+        "month" => {
+            get_timestamp_from_days(30)
+        }
+        "all" => {
+            0
+        }
+        _ => {
+            return get_error("Invalid duration".to_string());
+        }
+    };
 
     let leaderboard_pipeline = vec![
         doc! {