Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add deployed timestamp in db, create endpoint & update seniority… #117

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Oct 27, 2023

… achievement endpoint

Close #115

@irisdv irisdv requested a review from Th0rgal October 27, 2023 08:10
@irisdv irisdv added the 🔥 Ready for review This pull request needs a review label Oct 27, 2023
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the stored address standard

src/utils.rs Outdated
let deployed_times_collection: Collection<CompletedTasks> =
self.db.collection("deployed_times");
let filter = doc! { "addr": addr.to_string() };
let update = doc! { "$setOnInsert": { "addr": addr.to_string(), "timestamp": timestamp } };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use to_hex() to store addresses, that way it will be a lower case hexadecimal string with leading zeros like in apibara, will be helpful if we update to our own indexer.

@Th0rgal Th0rgal self-requested a review October 28, 2023 10:12
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit f45c47f into master Oct 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrease number of requests to starkscan transaction endpoint
2 participants