Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: add batched endpoint for tvl achievement #126

Merged
merged 5 commits into from
Nov 7, 2023
Merged

ref: add batched endpoint for tvl achievement #126

merged 5 commits into from
Nov 7, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Nov 6, 2023

This PR adds a new batched/verify_tvl_batched endpoint to avoid sending multiple request to Starkendefi api. It relies on having a new entry in the achievement_category collection override_verified_type

@irisdv irisdv requested a review from Th0rgal November 6, 2023 11:07
@irisdv irisdv added the 🔥 Ready for review This pull request needs a review label Nov 6, 2023
Th0rgal
Th0rgal approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit fe966cf into master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th0rgal Th0rgal Th0rgal approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irisdv @Th0rgal