feat: add rango quest #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtom
requested review from
irisdv and
Th0rgal
and removed request for
irisdv
|
Hey, can you give me the good answers to the quizz? |
Th0rgal
requested changes
Dec 11, 2023
| Err(e) => get_error(format!("{}", e)), | ||
| }; | ||
| } else { | ||
| get_error("User has not completed the task".to_string()) |
There was a problem hiding this comment.
Try to avoid repeating the same statement. You can try to use return inside the last if and return get_error "user hasn ot completed the tasks" only at the end. Will be easier if we want to modify it.
ayushtom
added
🔥 Ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/orgs/starknet-id/projects/1/views/10?pane=issue&itemId=42718114