Fix: Include quest completion timestamp in get_quest_participants response #359
+217
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TropicalDog17
changed the title
|
Hello @TropicalDog17 when will the PR be ready for review ? |
|
Hey please review this PR. Thank you so much! @Marchand-Nicolas |
| @@ -229,8 +229,10 @@ pub fn load() -> Config { | |||
| let args: Vec<String> = env::args().collect(); | |||
| let config_path = if args.len() <= 1 { | |||
| "config.toml" | |||
| } else { | |||
| } else if (args.len() > 1) && (args.get(1).unwrap().contains("toml")) { | |||
Marchand-Nicolas
requested changes
Jan 7, 2025
| @@ -26,4 +26,8 @@ pub mod tests { | |||
| let response = client.get(endpoint).send().await.unwrap(); | |||
| assert_eq!(response.status(), StatusCode::OK); | |||
| } | |||
|
|
|||
| // #[tokio::test] | |||
| // pub async fn test_get_quest_participants() { | |||
There was a problem hiding this comment.
You can remove this
| return (StatusCode::OK, Json(res)).into_response(); | ||
| (StatusCode::OK, Json(res)).into_response() | ||
| } | ||
| #[cfg(test)] |
There was a problem hiding this comment.
No need to have the tests, but it was a good idea to make sure everything was working. The problem is that if we run tests in production, it'll reset the db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #358