feat: hide hidden quests and block disabled ones #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the "disabled" field from existing
questscollection scheme by two new fields. Disabling a quest used to just be front end trick to hide a quest from the front page of the website. People could still find the quest id by looking at the API result and access it. Here is how this feature changes that:1)
disabledA disabled quest won't be accessible. You won't be able to find it in the list of quests, nor fetch the actual quest document required to display the quest page. Endpoints allowing to complete the tasks of this quest will still work so we should still update the quest server when we remove a quest, but this allows us to keep the database as it is.
2)
hiddenThis is similar to what we used to do when disabling quests, except this is server-side. You can still access the actual quest page, but even if you look at the API result, you won't be able to find the quest_id in the returned json.