Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse expiry timestamp #63

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix: parse expiry timestamp #63

merged 2 commits into from
Aug 11, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Aug 11, 2023

  • Adds a new variable expiry_timestamp in QuestDocument that parses expiry DateTime into String
  • updates get_quest to compare expiry and current timestamp, similarly to get_quests

@Th0rgal Th0rgal self-requested a review August 11, 2023 14:09
Th0rgal
Th0rgal approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit 6b6e8a6 into master Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th0rgal Th0rgal Th0rgal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irisdv @Th0rgal