Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: add img_url in BuildingDocument #75

Merged
merged 2 commits into from
Aug 31, 2023
Merged

ref: add img_url in BuildingDocument #75

merged 2 commits into from
Aug 31, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Aug 31, 2023 •
edited
Loading

  • add img_url in BuildingDocument
  • add response in error logs when an error occur when we deserialize the response

@Th0rgal Th0rgal self-requested a review August 31, 2023 08:22
Th0rgal
Th0rgal approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit 5712255 into master Aug 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th0rgal Th0rgal Th0rgal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irisdv @Th0rgal