feat: add auto renewal button #254
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| import React, { FunctionComponent, useEffect, useState } from "react"; | ||
| import { usePricingContract } from "../../../hooks/contracts"; | ||
| import styles from "../../../styles/components/wallets.module.css"; | ||
| import styles2 from "../../../styles/Home.module.css"; |
There was a problem hiding this comment.
Rename homeStyles instead of styles2
| </span> | ||
| </p> | ||
| )} | ||
| <div className={styles2.cardCenter}> |
There was a problem hiding this comment.
I don't think this is useful.
| )} | ||
| {identity?.domain_expiry && ( | ||
| <p className="break-all"> | ||
| <strong>Auto renewal date :</strong> |
There was a problem hiding this comment.
Can you make it really strong using the className strong in global.css ? Because right now it's not bold
| To avoid loosing your domain, you can enable auto renewals so your | ||
| domain is renewed automatically. Auto renewals happen one month before | ||
| your expiry date is reached. | ||
| </p> |
There was a problem hiding this comment.
Change text to
Avoid losing your domain and renew it automatically each year one month before it expires! (You can disable this option when you want.)| )} | ||
| </span> | ||
| </p> | ||
| )} |
There was a problem hiding this comment.
Here you can show the price like so:
<p className="break-all">
<strong>Price :</strong>
<span>
{price}/year
</span>
</p>
There was a problem hiding this comment.
After a few hours of testing on the front I have some problems on the build:
desc: I enabled auto renew, everything went great and the transaction passed right after (https://testnet.starkscan.co/tx/0x156a23df13a0aa924b20f783ebec3a07495d841f9cff2c6e49d18f61d47f6f3) but I still have some problems that made me thing that the tx wasn't passed.
1/ I enabled AR but the button ON still appears
2/ The tx is passed and worked but the indexer didn't index the time of the renewal. (I still have the same date displayed)
| <Renewal | ||
| groups={[ | ||
| process.env.NEXT_PUBLIC_MAILING_LIST_GROUP ?? "", | ||
| process.env.NEXT_PUBLIC_MAILING_LIST_GROUP_AUTO_RENEWAL ?? "", |
There was a problem hiding this comment.
en fait ici on a pas besoin de public mailing list ici juste process.env.NEXT_PUBLIC_MAILING_LIST_GROUP_AUTO_RENEWAL
There was a problem hiding this comment.
Mais seulement quand la checkbox auto renewal est checked du coup ?
There was a problem hiding this comment.
Ok du coup c'est bon
I think the same date should be displayed on the autorenewal button before and after the tx, because I precompute it in the button, and when you enable auto renewal this is the date that will be used (30 days before it expires). |
fricoben
added
❌ Change request
For this, it should be fixed now but we still have a bit of time between the tx being accepted and the event being indexed |
irisdv
added
🔥 Ready for review
| </a> | ||
| </p> | ||
| </div> | ||
| ) : null} |
There was a problem hiding this comment.
Delete for now (we'll soon add it back with new version)
| {identity?.domain_expiry | ||
| ? `Your domain will be renewed for 1 year on | ||
| ${timestampToReadableDate( | ||
| identity.domain_expiry - 2592000 |
There was a problem hiding this comment.
I guess 2592000 is the second equivalent to a month. We need to put that in a const for us to understand easily
| <Renewal | ||
| groups={[ | ||
| process.env.NEXT_PUBLIC_MAILING_LIST_GROUP ?? "", | ||
| process.env.NEXT_PUBLIC_MAILING_LIST_GROUP_AUTO_RENEWAL ?? "", |
fricoben
added
❌ Change request
Close #178
Adds a new button on root domains identity page to toggle auto renew of a domain.