feat: submenu dropdown #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marchand-Nicolas
added
the
🚧 In progress do not merge
|
|
Marchand-Nicolas
added
🔥 Ready for review
fricoben
requested changes
Nov 12, 2023
components/UI/navbar.tsx
Outdated
| @@ -247,6 +256,42 @@ const Navbar: FunctionComponent = () => { | |||
| Domains | |||
| </li> | |||
| </Link> | |||
| <Link href="/offers"> | |||
There was a problem hiding this comment.
Not available yet so you need to delete that My Offers
| href={`${ | ||
| process.env.NEXT_PUBLIC_STARKNET_ID as string | ||
| }/affiliates/individual-program`} | ||
| > |
There was a problem hiding this comment.
Can you for an opening of the link in another tab instead of using href. Because people will go to another website and we also want them to stay on our website. (you can use window.open or use other stuff within the Link component).
You can do the same for all the other links
components/UI/desktopNav.tsx
Outdated
| import { FaDiscord, FaGithub, FaTwitter } from "react-icons/fa"; | ||
| import theme from "../../styles/theme"; | ||
|
|
||
| const DesktopNav: FunctionComponent = () => { |
There was a problem hiding this comment.
On this component, I would like something where I can click outside the box and the box closes.
fricoben
added
❌ Change request
Marchand-Nicolas
added
🔥 Ready for review
fricoben
requested changes
Nov 14, 2023
fricoben
added
❌ Change request
Marchand-Nicolas
added
🔥 Ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #472