fix: subscription calldata #859

fricoben · 2024-07-19T12:41:10Z

close #811

Summary by CodeRabbit

New Features
- Enhanced subscription logic to include additional checks for available domains, preventing the subscription button from being enabled without any domains.
- Updated subscription button text to "You're already subscribed" when no domains are available, providing clearer user feedback.

vercel · 2024-07-19T12:41:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2024 3:26pm
sepolia-app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2024 3:26pm

coderabbitai · 2024-07-19T12:41:15Z

Walkthrough

The recent changes to the Subscription component enhance the user experience by adding validation checks to ensure that a subscription can only be enabled when valid domains are available. An additional condition checks if the callData array is empty, preventing the subscription button from being activated without available domains. The button's text has also been updated to clarify the subscription state, providing users with immediate feedback on their subscription status.

Changes

Files	Change Summary
components/domains/autorenewal.tsx	Added validation to ensure `callData` is not empty before enabling subscription; updated button text for clarity.

Assessment against linked issues

Objective	Addressed	Explanation
Notify user when already subscribed (Issue #811)	✅
Improve button feedback when no domains are available	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3dc9684 and 2aab42c.

Files selected for processing (1)

components/domains/autorenewal.tsx (2 hunks)

Additional comments not posted (2)

components/domains/autorenewal.tsx (2)

401-402: LGTM! The condition ensures the button is disabled when there are no domains to subscribe to.

The added condition !(callData.length > 0) ensures the subscription button is disabled when there are no domains available for subscription, providing appropriate feedback to the user.

411-413: LGTM! The button text provides clear feedback on the subscription state.

The updated button text "You're already subscribed" when callData.length is zero improves user experience by clearly indicating the subscription status.

Marchand-Nicolas · 2024-07-19T15:14:42Z

components/domains/autorenewal.tsx

@@ -398,7 +398,8 @@ const Subscription: FunctionComponent<SubscriptionProps> = ({ groups }) => {
                !address ||
                !termsBox ||
                (needMedadata && emailError) ||
-                !areDomainSelected(selectedDomains)
+                !areDomainSelected(selectedDomains) ||
+                !(callData.length > 0) // Cover the case where there are no domains to subscribe


!(callData.length > 0) is the same as callData.length === 0. Isn't it cleaner that way ?

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2aab42c and b5ee4af.

Files selected for processing (1)

components/domains/autorenewal.tsx (2 hunks)

Files skipped from review as they are similar to previous changes (1)

components/domains/autorenewal.tsx

Marchand-Nicolas

lgtm

fix: subscription calldata

2aab42c

fricoben added the 🔥 Ready for review This pull request needs a review label Jul 19, 2024

vercel bot deployed to Preview – app-starknet-id July 19, 2024 12:41 View deployment

vercel bot deployed to Preview – sepolia-app-starknet-id July 19, 2024 12:42 View deployment

coderabbitai bot reviewed Jul 19, 2024

View reviewed changes

Marchand-Nicolas requested changes Jul 19, 2024

View reviewed changes

fix: refview

b5ee4af

vercel bot deployed to Preview – app-starknet-id July 19, 2024 15:25 View deployment

coderabbitai bot reviewed Jul 19, 2024

View reviewed changes

Marchand-Nicolas approved these changes Jul 19, 2024

View reviewed changes

vercel bot deployed to Preview – sepolia-app-starknet-id July 19, 2024 15:26 View deployment

fricoben merged commit 88da332 into testnet Jul 22, 2024
4 checks passed

coderabbitai bot mentioned this pull request Sep 23, 2024

ref: identity warnings #887

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: subscription calldata #859

fix: subscription calldata #859

fricoben commented Jul 19, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 19, 2024 •

edited

Loading

coderabbitai bot commented Jul 19, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

Marchand-Nicolas Jul 19, 2024

fricoben Jul 19, 2024

coderabbitai bot left a comment

Marchand-Nicolas left a comment

fix: subscription calldata #859

fix: subscription calldata #859

Conversation

fricoben commented Jul 19, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

vercel bot commented Jul 19, 2024 • edited Loading

coderabbitai bot commented Jul 19, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

Marchand-Nicolas Jul 19, 2024

Choose a reason for hiding this comment

fricoben Jul 19, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

Marchand-Nicolas left a comment

Choose a reason for hiding this comment

fricoben commented Jul 19, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 19, 2024 •

edited

Loading

coderabbitai bot commented Jul 19, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)