Adds missing features #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request marks the completion of the migration process for the identity contract to Cairo version 2. The migration was tested on the testnet with the deployment of a Cairo Zero version. Steps taken included minting a starknetid, modifying several of its fields, and executing a two-stage upgrade process. The first upgrade involved changing the proxy class hash target, followed by a call to
finalize_migration(), and a subsequent upgrade to update the contract class hash. The data integrity was maintained: I still owned my identities and they still held their values. Thefinalize_migrationfunction is designed to update the contract owner. Both upgrades proceeded without any issues, validating the migration strategy.When this pull request is merged, I will work on adapting the indexers and upgrade the official goerli contract.
closes: lfglabs-dev/contract_cairo1#2