fix: ability to override a subdomain with a domain

lfglabs-dev · Dec 20, 2023 · 116da37 · 116da37
1 parent 7edd27a
commit 116da37
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/naming/asserts.cairo b/src/naming/asserts.cairo
@@ -99,8 +99,9 @@ impl AssertionsImpl of AssertionsTrait {
             contract_address: self.starknetid_contract.read()
         }
             .get_verifier_data(identity, 'name', get_contract_address(), 0);
+        let domain_expiry = self._domain_data.read(id_hashed_domain).expiry;
         assert(
-            id_hashed_domain == 0 || self._domain_data.read(id_hashed_domain).expiry < timestamp,
+            id_hashed_domain == 0 || (domain_expiry != 0 && domain_expiry < timestamp),
             'this id holds a domain'
         );
     }