fix: overriding a subdomain by a root domain (#20)

lfglabs-dev · Jan 12, 2024 · 6e45f7f · 6e45f7f
1 parent b327ec1
commit 6e45f7f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/naming/internal.cairo b/src/naming/internal.cairo
@@ -44,13 +44,15 @@ impl InternalImpl of InternalTrait {
     fn set_address_to_domain_util(
         ref self: Naming::ContractState, address: ContractAddress, mut domain: Span<felt252>
     ) {
-        match domain.pop_back() {
-            Option::Some(domain_part) => {
-                self._address_to_domain.write((address, domain.len()), *domain_part);
-                self.set_address_to_domain_util(address, domain)
-            },
-            Option::None => {}
-        }
+        self._address_to_domain.write((address, domain.len()), 0);
+        loop {
+            match domain.pop_back() {
+                Option::Some(domain_part) => {
+                    self._address_to_domain.write((address, domain.len()), *domain_part);
+                },
+                Option::None => { break; }
+            }
+        };
     }
 
     fn domain_to_resolver(

diff --git a/src/naming/main.cairo b/src/naming/main.cairo
@@ -247,7 +247,6 @@ mod Naming {
             }
         }
 
-
         // EXTERNAL
 
         fn buy(
-Original file line number
+Diff line change
@@ Expand Up / @@ -247,7 +247,6 @@ mod Naming { @@
                 }
             }
             // EXTERNAL
             fn buy(
@@ Expand Down @@