Merge pull request #55 from starknet-id/fix/returning0_as_hashed_domain

fix: return hashed_domain if resolver returns 0
lfglabs-dev · May 28, 2024 · a62d868 · a62d868
2 parents 052aabe + aef5a63
commit a62d868
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/naming/internal.cairo b/src/naming/internal.cairo
@@ -147,11 +147,13 @@ impl InternalImpl of InternalTrait {
     ) -> (felt252, felt252) {
         let (resolver, parent_start) = self.domain_to_resolver(domain, 1);
         if (resolver != ContractAddressZeroable::zero()) {
-            (
-                0,
-                IResolverDispatcher { contract_address: resolver }
-                    .resolve(domain.slice(0, parent_start), field, hint)
-            )
+            let resolver_res = IResolverDispatcher { contract_address: resolver }
+                .resolve(domain.slice(0, parent_start), field, hint);
+            if resolver_res == 0 {
+                let hashed_domain = self.hash_domain(domain);
+                return (0, hashed_domain);
+            }
+            return (0, resolver_res);
         } else {
             let hashed_domain = self.hash_domain(domain);
             let domain_data = self._domain_data.read(hashed_domain);