Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hint #13

Merged
merged 7 commits into from
Nov 7, 2023
Merged

feat: add hint #13

merged 7 commits into from
Nov 7, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Nov 1, 2023 •
edited
Loading

This PR is part of #4 . It :

  • adds hint to resolve and domain_to_address functions
  • adds function set_domain_to_resolver

@irisdv irisdv requested a review from Th0rgal November 2, 2023 10:30
@irisdv irisdv added 🔥 Ready for review Pull Request needs a 🚧 In progress do not merge Pull Request in progress, please do not merge and removed 🔥 Ready for review Pull Request needs a labels Nov 2, 2023
@irisdv irisdv added 🔥 Ready for review Pull Request needs a and removed 🚧 In progress do not merge Pull Request in progress, please do not merge labels Nov 2, 2023
Th0rgal
Th0rgal approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit b9bb094 into master Nov 7, 2023
3 checks passed
@Th0rgal Th0rgal mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th0rgal Th0rgal Th0rgal approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review Pull Request needs a
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irisdv @Th0rgal