Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/test use reset subdomains multiple levels #63

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented Jun 12, 2024

closes #38

@Th0rgal Th0rgal requested a review from irisdv June 12, 2024 17:34
@Th0rgal Th0rgal self-assigned this Jun 12, 2024
@Th0rgal Th0rgal added the 🔥 Ready for review Pull Request needs a label Jun 12, 2024
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left some small comments about comment updates, otherwise lgtm

@@ -311,6 +311,72 @@ fn test_transfer_from_returns_false() {
.buy(1, aller, 365, ContractAddressZeroable::zero(), ContractAddressZeroable::zero(), 0, 0);
}

#[test]
#[available_gas(2000000000)]
//#[should_panic(expected: ('a parent domain was reset', 'ENTRYPOINT_FAILED'))]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment can be removed

let subsubsubdomain = array!['example', 'aaaaa', 'bbbbb', 'ccccc'].span();
naming.transfer_domain(subsubsubdomain, 4);

// alpha resets subdomains of aller.stark
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ccccc.stark instead of aller.stark in the comment

@Th0rgal Th0rgal merged commit 0fcffd3 into testnet Jun 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review Pull Request needs a
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[audit] Fix reset subdomains multiple levels
2 participants