-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/test use reset subdomains multiple levels #63
Fix/test use reset subdomains multiple levels #63
Conversation
Bring fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left some small comments about comment updates, otherwise lgtm
src/tests/naming/test_abuses.cairo
Outdated
@@ -311,6 +311,72 @@ fn test_transfer_from_returns_false() { | |||
.buy(1, aller, 365, ContractAddressZeroable::zero(), ContractAddressZeroable::zero(), 0, 0); | |||
} | |||
|
|||
#[test] | |||
#[available_gas(2000000000)] | |||
//#[should_panic(expected: ('a parent domain was reset', 'ENTRYPOINT_FAILED'))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment can be removed
src/tests/naming/test_abuses.cairo
Outdated
let subsubsubdomain = array!['example', 'aaaaa', 'bbbbb', 'ccccc'].span(); | ||
naming.transfer_domain(subsubsubdomain, 4); | ||
|
||
// alpha resets subdomains of aller.stark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be ccccc.stark
instead of aller.stark
in the comment
closes #38