Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was requested by Argent as part of their initiative to distribute
argent.stark
subdomains via a smartcontract using our native resolver. It introduces arevoke_domain
function which can be used by the controller of a domain (i.e. its direct owner or the owner of one of its parents) to reset the specified domain and its subdomains recursively. This comes with a test ensuring the controller's domain is not reset and reset works fine for the specified subdomains and its own recursive subdomains. It doesn't test forassert_control_domain
feature as it is already tested separately.It also introduces a fix for a small bug found by Leo from Argent where following these steps:
Would result in a panic instead of resolving to 0 (panic should happen only when cairo introduces try/catch).