Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/argent features #67

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Feat/argent features #67

merged 2 commits into from
Jul 15, 2024

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented Jul 13, 2024

This pull request was requested by Argent as part of their initiative to distribute argent.stark subdomains via a smartcontract using our native resolver. It introduces a revoke_domain function which can be used by the controller of a domain (i.e. its direct owner or the owner of one of its parents) to reset the specified domain and its subdomains recursively. This comes with a test ensuring the controller's domain is not reset and reset works fine for the specified subdomains and its own recursive subdomains. It doesn't test for assert_control_domain feature as it is already tested separately.

It also introduces a fix for a small bug found by Leo from Argent where following these steps:

  1. Register subdomain (call transfer_domain)
  2. Set main id
  3. Call transfer_domain again (on the same subdomain)
  4. Call address_to_domain
    Would result in a panic instead of resolving to 0 (panic should happen only when cairo introduces try/catch).

@Th0rgal Th0rgal self-assigned this Jul 13, 2024
@Th0rgal Th0rgal added the 🔥 Ready for review Pull Request needs a label Jul 13, 2024
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@irisdv irisdv merged commit ac3f6c8 into testnet Jul 15, 2024
3 checks passed
@Th0rgal Th0rgal mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review Pull Request needs a
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants