Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Landing #101

Open
Kevils opened this issue Jan 28, 2025 · 12 comments · May be fixed by #104
Open

Feedback Landing #101

Kevils opened this issue Jan 28, 2025 · 12 comments · May be fixed by #104
Assignees
Labels
Good first issue Good for newcomers OD Boost Issue reserved for the OD Boost Open for contribution An issue that is available for an Only Dust contribution

Comments

@Kevils
Copy link
Collaborator

Kevils commented Jan 28, 2025

Description 📹

1 - The proportion of the header image is too small. I think we can enlarge it to 500x500px. Also, the two small leaves around the image are missing. Here's the correct file to use : Header image.png.zip

Current :
Image

New design :
Image

Figma file : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4040-8018&t=Z7UwxvO5x57HzGQx-1

**2 - The leaves used are static, poorly positioned on the page (they should be in the Starknet Identity section), and they are not the animated Lottie files. They need to be correctly positioned in the right section, and the Lotties should be used: Falling leaf.json
**
Current :
Image
Image

New design :
Image

Figma file : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4040-8018&t=Z7UwxvO5x57HzGQx-1

**3 - The logos are much too small because I think there are too many visible. They need to be enlarged, like in the design.
**

Current :
Image

New design :
Image

Figma file : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4040-8018&t=Z7UwxvO5x57HzGQx-1

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Kevils Kevils added Good first issue Good for newcomers Open for contribution An issue that is available for an Only Dust contribution and removed Open for contribution An issue that is available for an Only Dust contribution Good first issue Good for newcomers labels Jan 28, 2025
@Marchand-Nicolas Marchand-Nicolas added OD Boost Issue reserved for the OD Boost Open for contribution An issue that is available for an Only Dust contribution Good first issue Good for newcomers labels Jan 28, 2025
@Benjtalkshow
Copy link

@Marchand-Nicolas
I can handle this.

@SudiptaPaul-31
Copy link

Would love to work on this

@michojekunle
Copy link

Can I take this on?

@OWK50GA
Copy link

OWK50GA commented Jan 28, 2025

Hi, can I take this on?

@mimisavage
Copy link

I’d like to resolve this.

@wheval
Copy link

wheval commented Jan 28, 2025

Can i get this done ?

@youngancient
Copy link
Contributor

Hi, I am YoungAncient, a first-time OD contributor. I'd love to take on this issue because I have a thing for pixel-perfect implementation example, and I will deliver within the stated ETA.

@peternnadi1999
Copy link

I'm a first time ODHACK contributor. I would love to work on this as my first issue

@Emmanex01
Copy link

I would love to handle this issue 🙏?

@Ved-viraj
Copy link

Can I take on this task please? I have gone through the requirement and I can do it. This is my first contribution and I can do this one.

@Benjtalkshow
Copy link

@Benjtalkshow
Just saw this. Will start working now.Thanks

@Benjtalkshow
Copy link

Will make a draft PR soon

@Benjtalkshow Benjtalkshow linked a pull request Jan 29, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers OD Boost Issue reserved for the OD Boost Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.