-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback Landing #101
Comments
@Marchand-Nicolas |
Would love to work on this |
Can I take this on? |
Hi, can I take this on? |
I’d like to resolve this. |
Can i get this done ? |
Hi, I am YoungAncient, a first-time OD contributor. I'd love to take on this issue because I have a thing for pixel-perfect implementation example, and I will deliver within the stated ETA. |
I'm a first time ODHACK contributor. I would love to work on this as my first issue |
I would love to handle this issue 🙏? |
Can I take on this task please? I have gone through the requirement and I can do it. This is my first contribution and I can do this one. |
@Benjtalkshow |
Will make a draft PR soon |
Description 📹
1 - The proportion of the header image is too small. I think we can enlarge it to 500x500px. Also, the two small leaves around the image are missing. Here's the correct file to use : Header image.png.zip
Current :
New design :
Figma file : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4040-8018&t=Z7UwxvO5x57HzGQx-1
**2 - The leaves used are static, poorly positioned on the page (they should be in the Starknet Identity section), and they are not the animated Lottie files. They need to be correctly positioned in the right section, and the Lotties should be used: Falling leaf.json
**
Current :
New design :
Figma file : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4040-8018&t=Z7UwxvO5x57HzGQx-1
**3 - The logos are much too small because I think there are too many visible. They need to be enlarged, like in the design.
**
Current :
New design :
Figma file : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4040-8018&t=Z7UwxvO5x57HzGQx-1
Proposed Actions 🛠️
Here’s a checklist of actions to follow for resolving this issue:
Fork and Create Branch:
Fork the repository and create a new branch using the issue number:
Implement Changes:
[Insert Code snippet if needed with a mardown todo list]
Run Tests and Commit Changes:
Make sure your changes don't break existing functionality and commit with a clear message:
git commit -m "Fix: [Short description of the fix]"
Required 📋
To keep our workflow smooth, please make sure you follow these guidelines:
Close #[issue_id]
.Thank you for your contribution 🙏
The text was updated successfully, but these errors were encountered: