Fix: Feedback Landing page #104
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Benjtalkshow is attempting to deploy a commit to the LFG Labs Team on Vercel. A member of the Team first needs to authorize it. |
components/home/headerBanner.tsx
Outdated
| @@ -5,8 +5,10 @@ const HeaderBanner: FunctionComponent = () => { | |||
| return ( | |||
| <img | |||
| alt="Header banner" | |||
| src="/visuals/home/headerBanner.webp" | |||
| src="/visuals/home/headerImage.png" | |||
There was a problem hiding this comment.
Please use png format, not webp.
In addition, the image doesn't load, please test your code
There was a problem hiding this comment.
@Marchand-Nicolas
Do you mean i should use webp format instead of png? Because what i used is png format.
Additionally, i am wondering why the image is not loading from your end because it loads properly from my localhost and i tested it properly before pushing.
There was a problem hiding this comment.
@Benjtalkshow
Yes, you should use webp, not png, sorry, just saw I inverted in my comment!
For the image that doesn't load in production but loads in local, there can be two options:
- Either one letter should/shouldn't be uppercase in the image path. From my experience, the links are only case sensitive in production.
- Or, you use the CDNImg component. If so, you can replace it by the Image component from next/image
There was a problem hiding this comment.
@Marchand-Nicolas ,
I have fixed the headerBanner. But i noticed argent wallet, starkscan and braavos icons arent displaying too.
There was a problem hiding this comment.
@Marchand-Nicolas , I have fixed the headerBanner. But i noticed argent wallet, starkscan and braavos icons arent displaying too.
Ah, where do you see t-it ? Can you send me a screenshot please @Benjtalkshow
There was a problem hiding this comment.
| @@ -5,8 +5,10 @@ const HeaderBanner: FunctionComponent = () => { | |||
| return ( | |||
| <img | |||
| alt="Header banner" | |||
| src="/visuals/home/headerBanner.webp" | |||
There was a problem hiding this comment.
If you add a new headerImage.webp file, then delete the headerBanner.webp file as it's not used anymore
|
@Marchand-Nicolas |
|
|
Hello @Benjtalkshow I think it loads in production and not locally because the files doesn't exist (with that exact names), but the contributor used the CDNImg component, which makes it working in prod (because it uses the cached assets). |
Alright sir. |
|
@Marchand-Nicolas |
Closes #101
For the task 1 "Changing the size of the header banner", i used 700 x 700 because i noticed that 500x500 was still small.