Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: number of steps and participants #248

Merged
merged 4 commits into from
Oct 19, 2023
Merged

feat: number of steps and participants #248

merged 4 commits into from
Oct 19, 2023

Conversation

Marchand-Nicolas
Copy link
Collaborator

close: #192

Needs lfglabs-dev/api.starknet.quest#95 in order to work

@vercel
Copy link

vercel bot commented Oct 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 1:56pm
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 1:56pm

@Marchand-Nicolas Marchand-Nicolas added the 🔥 Ready for review The PR is now ready for review label Oct 15, 2023
fricoben
fricoben requested changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the variable d'env

components/quests/questDetails.tsx Outdated Show resolved Hide resolved
@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review The PR is now ready for review labels Oct 15, 2023
@Marchand-Nicolas Marchand-Nicolas added 🔥 Ready for review The PR is now ready for review and removed ❌ Change request Change requested from reviewer labels Oct 16, 2023
@fricoben fricoben requested a review from irisdv October 17, 2023 05:18
irisdv
irisdv requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a juste un soucis de var d'env je pense, on a mis à jour le serveur avec ta PR donc tu peux tester sur ton build le résultat

components/quests/questDetails.tsx Show resolved Hide resolved
@irisdv irisdv added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review The PR is now ready for review labels Oct 17, 2023
@irisdv irisdv self-requested a review October 18, 2023 13:58
irisdv
irisdv approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@irisdv irisdv requested a review from fricoben October 18, 2023 13:58
@irisdv irisdv added 🔥 Ready for review The PR is now ready for review and removed ❌ Change request Change requested from reviewer labels Oct 18, 2023
fricoben
fricoben approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fricoben fricoben merged commit 5ca04f4 into testnet Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irisdv irisdv irisdv approved these changes

@fricoben fricoben fricoben approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review The PR is now ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of steps and participants
3 participants
@Marchand-Nicolas @irisdv @fricoben