Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Add naming conventions to documentation #189

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Chore: Add naming conventions to documentation #189

merged 1 commit into from
Dec 11, 2024

Conversation

ModeSevenIndustrialSolutions
Copy link
Contributor

@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions commented Oct 9, 2024 •
edited
Loading

Will pass linting if/when we merge: #188

@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions force-pushed the update-docs branch 6 times, most recently from c4d9fbe to 442a7b4 Compare October 23, 2024 17:54
tykeal
tykeal reviewed Oct 23, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
tykeal
tykeal reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@tykeal tykeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm being a little pedantic, but I would like the idea around the generic Gerrit workflows to be reworked. See my comment in the file itself.

@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions force-pushed the update-docs branch 2 times, most recently from fd45176 to ebe5a54 Compare October 24, 2024 00:05
@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions force-pushed the update-docs branch 4 times, most recently from f0b51c1 to 49f65d3 Compare October 30, 2024 12:50
tykeal
tykeal requested changes Nov 1, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions force-pushed the update-docs branch 2 times, most recently from 88b348b to 7a5e8ac Compare November 6, 2024 00:07
eb-oss
eb-oss requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@eb-oss eb-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted a couple small corrections to be made, but I think this is a solid starting point for both our naming scheme, and our overall documentation.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tykeal
tykeal reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@tykeal tykeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. Please adress @eb-oss 's comments though

README.md Show resolved Hide resolved
@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions force-pushed the update-docs branch 2 times, most recently from 28239de to d8cbc66 Compare December 10, 2024 10:39
@tykeal tykeal enabled auto-merge December 11, 2024 17:50
@tykeal
Copy link
Member

tykeal commented Dec 11, 2024

@ModeSevenIndustrialSolutions need to rebase onto current HEAD and it's good to go.

@tykeal tykeal disabled auto-merge December 11, 2024 21:06
@tykeal tykeal merged commit 1aff632 into lfit:main Dec 11, 2024
4 checks passed
@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions deleted the update-docs branch January 19, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb-oss eb-oss eb-oss approved these changes

@tykeal tykeal tykeal approved these changes

Assignees

@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ModeSevenIndustrialSolutions @tykeal @eb-oss