Skip to content

Commit

Permalink
make sure the components are rendered before checking them
Browse files Browse the repository at this point in the history
  • Loading branch information
@lfoppiano
lfoppiano committed Aug 16, 2024
1 parent 788035d commit 1214cd2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/test_resolution_boost.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ def go_to_app(page: Page, streamlit_app: StreamlitRunner):
page.get_by_role("img", name="Running...").is_hidden()


def test_should_render_template_check_container_size(page: Page):
def test_resolution_boost(page: Page):
expect(page.get_by_text("Test PDF Viewer with different resolution boosts")).to_be_visible()
page.wait_for_selector('iframe[title="streamlit_pdf_viewer.streamlit_pdf_viewer"]')
page.locator('iframe[title="streamlit_pdf_viewer.streamlit_pdf_viewer"]').nth(6)
page.locator('iframe[title="streamlit_pdf_viewer.streamlit_pdf_viewer"]').nth(6).wait_for("visible")

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.7, 18) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.7, 18) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.7, 20) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.7, 20) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.8, 18) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.8, 18) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.8, 20) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.8, 20) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.9, 18) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.9, 18) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.9, 20) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.9, 20) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.10, 18) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.10, 18) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.10, 20) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.10, 20) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.11, 18) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.11, 18) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.11, 20) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.11, 20) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.12, 18) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.12, 18) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.12, 20) 

test_resolution_boost[firefox]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given

Check failure on line 39 in tests/test_resolution_boost.py

View workflow job for this annotation

GitHub Actions / build (3.12, 20) 

test_resolution_boost[chromium]

TypeError: Locator.wait_for() takes 1 positional argument but 2 were given
iframe_components = page.locator('iframe[title="streamlit_pdf_viewer.streamlit_pdf_viewer"]').all()
assert len(iframe_components) == 6

Expand Down

0 comments on commit 1214cd2

Please sign in to comment.