Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iwslt 2022 dialect #656

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

m-wiesner
Copy link
Contributor

Adds recipe for Tunisian Dialect data used in the iwslt2022 dialectal speech translation task.

except ImportError:
import pip

pip._internal.main(["install", "pyarabic"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart trick, but as a user I would be extremely surprised if importing Lhotse triggered a pip install command. Please handle missing optional dependencies in the same way as throughout the rest of the code, see e.g. here:

if is_module_available("speechcolab"):
from speechcolab.datasets.gigaspeech import GigaSpeech
else:
raise ImportError(
"To process the GigaSpeech corpus, please install optional dependency: pip install speechcolab"
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants