Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe the output of ffmpeg to cat before reading it. #675

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

csukuangfj
Copy link
Contributor

@danpovey
Copy link
Collaborator

After looking at the size of reads, it seems that this does not resolve the problem. I suspect it was not really faster, e.g. we were comparing across machines with different properties. We should double-check though; if it was faster, it is worth investigating why.

@pzelasko
Copy link
Collaborator

Let me know once you think it's good to merge it.

@pzelasko
Copy link
Collaborator

pzelasko commented May 3, 2022

Did you reach any conclusions? I can just merge it as it won't break anything, but it would be good to know if it really helps.

@danpovey
Copy link
Collaborator

danpovey commented May 3, 2022

Personally I don't believe this can be helping, even though it appeared to.
From strace output, it doesn't seem to affect the chunk sizes it's read in; and I don't believe cat actually does any buffering.
But if the effect can be replicated I suppose we'd have to find an explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants