-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Pedal Board Schematic #1
base: main
Are you sure you want to change the base?
Conversation
Break fluid pressure circuitry and excludes potentiometer for the pedal position sensor.
You should have bypass caps on the on the output of the 5V buck to clean the 5V power The peripheralSOM's ADC uses GND, but the signal for the brake is referenced to GNDPWR. You need some form of isolation to take the input signal which is referenced to GNDPWR and make it GND. Amperes is doing smth similar if you want to see how that is implemented: https://github.com/lhr-solar/BPS-AmperesPCB Look on mouser to see if you can find a high precision resistor that matches what you need for the shunt resistor, since 160 ohms is a bit of an awkward value Use a bidirectional TVS diode for the 12V input (to prevent transients from GND going into it). See the powerDist sheet of the psom for what TVS to use: https://github.com/lhr-solar/PeripheralSOMPCB/tree/v2.1 For the accelerator i'd do what the datasheet suggests and add a buffer for the ADC signal. |
I wanted to ask, partly just for myself, why the circuit has to be isolated? It isn't connected to HV and all of the components would be powered off of the single 12v power supply, so there wouldn't be ground loop issues from what I know. The main reason I bring this up is because you are using an isolated amplifier for your brake sensor. The way these amplifiers work is they use an ADC internally to digitize and transfer the voltage value across the isolation barrier, which is read by a DAC and outputted. The issue with this in the context of sensors is that you lose a degree of precision each time you perform a conversion between analog and digital. Since you will ADC the value again in the microprocessor, you could compound the error and get less accurate readings. However it is possible in your application the precision of the measurement doesn't matter as much, in which case this isn't a concern. If the board has to be isolated and absolutely has to have a very precise signal, then you could add an ADC to the board, and use an isolator to bring the digital signal across the isolation barrier, in which case you wouldn't lose any precision. |
It rlly doesn't need to be isolated in the general case, but the reason has isolation is cuz that's how we designed the PeripheralSOM because of the isolation requirement of BPS. So since BPS had an isolation requirement for PeripheralSOMs so everyone needs to work within those bounds. In the future, I would like for everyone to develop their own SOM version so BPS can make their own SOM with isolation and everyone else can make something without isolation. Isolation doesn't rlly lose you that much precision compared to the precision lost in an STM's ADC, i.e you do lose precision but not enough for an STM's ADC to notice. Isolation is iffy for analog signals cuz you can add a good amount of thermal noise to the output signal that you need to add heavier filtering for. For your point about GND loops, isolation is one of the ways you can avoid GND loops and it's something we did in the past for CAN and some other signals, but for 2026 car (Solar Mcqueen) we can avoid GND loop problems by relegating inter-board communications to just a CAN that shares the same GND as the fusebox. |
Agree with Lakshay on the CAN connectors being a little far from one another. Most of your test points are pads, which should be fine for power since its probably not being tested very frequently, but making them the little clip ones might be better. Also, not sure if necessary, but having testpoints for the accel and brake values might be helpful for debugging purposes (maybe?). |
Includes Break fluid pressure circuitry and excludes potentiometer for the pedal position sensor.
Quality Assurance Checklist
To make reviews more efficient, please make sure the board meets the following standards and check everything off once the board meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.
There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.
Minimum Prerequisites
2D Spacing
3D Spacing
Components
Copper Layer
*Not really a problem for modern manufacturing techniques but good practice and important for high speed signal integrity.
Silkscreen Layer
Edge Cut Layer
IMPORTANT NOTICE
Other Comments
Write any comments about the board that would help the reviewers here.