address comments

Signed-off-by: lhy1024 <[email protected]>
lhy1024 · Nov 1, 2024 · 64f12cc · 64f12cc
1 parent c20a4f9
commit 64f12cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/pkg/versioninfo/versioninfo.go b/pkg/versioninfo/versioninfo.go
@@ -31,7 +31,7 @@ type Status struct {
 	Version        string `json:"version"`
 	GitHash        string `json:"git_hash"`
 	StartTimestamp int64  `json:"start_timestamp"`
-	AreRegionsLoaded bool `json:"are_regions_loaded"`
+	Loaded         bool   `json:"loaded"`
 }
 
 const (

diff --git a/server/api/status.go b/server/api/status.go
@@ -40,13 +40,12 @@ func newStatusHandler(svr *server.Server, rd *render.Render) *statusHandler {
 // @Success  200  {object}  versioninfo.Status
 // @Router   /status [get]
 func (h *statusHandler) GetPDStatus(w http.ResponseWriter, _ *http.Request) {
-	areRegionsLoaded := storage.AreRegionsLoaded(h.svr.GetStorage())
 	version := versioninfo.Status{
-		BuildTS:          versioninfo.PDBuildTS,
-		GitHash:          versioninfo.PDGitHash,
-		Version:          versioninfo.PDReleaseVersion,
-		StartTimestamp:   h.svr.StartTimestamp(),
-		AreRegionsLoaded: areRegionsLoaded,
+		BuildTS:        versioninfo.PDBuildTS,
+		GitHash:        versioninfo.PDGitHash,
+		Version:        versioninfo.PDReleaseVersion,
+		StartTimestamp: h.svr.StartTimestamp(),
+		Loaded:         storage.AreRegionsLoaded(h.svr.GetStorage()),
 	}
 
 	h.rd.JSON(w, http.StatusOK, version)