mcs: fix datarace in keyspace group

Signed-off-by: lhy1024 <[email protected]>
lhy1024 · Jun 29, 2023 · 6c7c945 · 6c7c945
1 parent fa721e7
commit 6c7c945
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/tso/keyspace_group_manager.go b/pkg/tso/keyspace_group_manager.go
@@ -109,7 +109,12 @@ func (s *state) getKeyspaceGroupMeta(
 ) (*AllocatorManager, *endpoint.KeyspaceGroup) {
 	s.RLock()
 	defer s.RUnlock()
-	return s.ams[groupID], s.kgs[groupID]
+	am := s.ams[groupID]
+	if s.kgs[groupID] == nil {
+		return am, nil
+	}
+	kg := *s.kgs[groupID] // copy the keyspace group meta to avoid datarace
+	return am, &kg
 }
 
 // getKeyspaceGroupMetaWithCheck returns the keyspace group meta of the given keyspace.