address comments

Signed-off-by: lhy1024 <[email protected]>
lhy1024 · Nov 12, 2024 · bc7428b · bc7428b
1 parent 9c9e931
commit bc7428b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pkg/versioninfo/versioninfo.go b/pkg/versioninfo/versioninfo.go
@@ -31,7 +31,7 @@ type Status struct {
 	Version        string `json:"version"`
 	GitHash        string `json:"git_hash"`
 	StartTimestamp int64  `json:"start_timestamp"`
-	Loaded         bool   `json:"loaded"`
+	RegionLoaded   bool   `json:"region_loaded"`
 }
 
 const (

diff --git a/server/api/status.go b/server/api/status.go
@@ -45,7 +45,7 @@ func (h *statusHandler) GetPDStatus(w http.ResponseWriter, _ *http.Request) {
 		GitHash:        versioninfo.PDGitHash,
 		Version:        versioninfo.PDReleaseVersion,
 		StartTimestamp: h.svr.StartTimestamp(),
-		Loaded:         storage.AreRegionsLoaded(h.svr.GetStorage()),
+		RegionLoaded:   storage.AreRegionsLoaded(h.svr.GetStorage()),
 	}
 
 	h.rd.JSON(w, http.StatusOK, version)

diff --git a/server/api/status_test.go b/server/api/status_test.go
@@ -52,7 +52,7 @@ func checkStatusResponse(re *require.Assertions, body []byte) {
 	re.Equal(versioninfo.PDBuildTS, got.BuildTS)
 	re.Equal(versioninfo.PDGitHash, got.GitHash)
 	re.Equal(versioninfo.PDReleaseVersion, got.Version)
-	re.Equal(false, got.Loaded)
+	re.False(got.RegionLoaded)
 	gotWithOldStatus := oldStatus{}
 	re.NoError(json.Unmarshal(body, &gotWithOldStatus))
 	re.Equal(versioninfo.PDBuildTS, gotWithOldStatus.BuildTS)