Skip to content

🎉 trial of CommandPalette feature #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Conversation

tnyo43
Copy link
Member

@tnyo43 tnyo43 commented May 22, 2025

Issue

  • resolve:

Why is this change needed?

What would you like reviewers to focus on?

Testing Verification

What was done

pr_agent:summary

Detailed Changes

pr_agent:walkthrough

Additional Notes

Copy link

changeset-bot bot commented May 22, 2025

⚠️ No Changeset found

Latest commit: 86d0868

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liam-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 11:16pm
liam-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 11:16pm
liam-erd-sample ✅ Ready (Inspect) Visit Preview May 30, 2025 11:16pm
liam-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 11:16pm

Copy link

supabase bot commented May 22, 2025

Updates to Preview Branch (trial-command-palette) ↗︎

Deployments Status Updated
Database Fri, 30 May 2025 23:12:09 UTC
Services Fri, 30 May 2025 23:12:09 UTC
APIs Fri, 30 May 2025 23:12:09 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Fri, 30 May 2025 23:12:18 UTC
Migrations Fri, 30 May 2025 23:12:18 UTC
Seeding Fri, 30 May 2025 23:12:18 UTC
Edge Functions Fri, 30 May 2025 23:12:18 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

…c item when using mouse but not keyboard

When use click an item, it focuses on the item. While it's in super focus mode, the preview is fixed with the item and won't be updated by hovering other items. The super-focus state is disabled by clicking other items or close the dialog.
the problem about focus trap is resolved. The issue was caused by the difference of the version of @radix-ui/react-dialog
Copy link
Contributor

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: _e2e-tests (chromium)

Failed stage: Run e2e tests [❌]

Failed test name: top

Failure summary:

The action failed because the visual regression test (VRT) named "top" failed. The test is located
at line 24 in the file tests/vrt/vrt.test.ts. The test failed because the actual screenshot did not
match the expected screenshot - approximately 565-619 pixels (about 1% of all image pixels) were
different between the actual and expected images. The test was retried 5 times but continued to fail
with the same issue.

Relevant error logs:
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

215:  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
216:  Progress: resolved 2196, reused 0, downloaded 100, added 43
217:  Progress: resolved 2196, reused 0, downloaded 255, added 127
218:  Progress: resolved 2196, reused 0, downloaded 451, added 252
219:  Progress: resolved 2196, reused 0, downloaded 598, added 434
220:  Progress: resolved 2196, reused 0, downloaded 787, added 629
221:  Progress: resolved 2196, reused 0, downloaded 870, added 670
222:  Progress: resolved 2196, reused 0, downloaded 885, added 675
223:  Progress: resolved 2196, reused 0, downloaded 952, added 789
224:  Progress: resolved 2196, reused 0, downloaded 1114, added 886
225:  Progress: resolved 2196, reused 0, downloaded 1242, added 965
226:  Progress: resolved 2196, reused 0, downloaded 1521, added 1456
227:  Progress: resolved 2196, reused 0, downloaded 1869, added 1875
228:  Progress: resolved 2196, reused 0, downloaded 2046, added 2013
229:  Progress: resolved 2196, reused 0, downloaded 2189, added 2196, done
230:  WARN  Failed to create bin at /home/runner/work/liam/liam/node_modules/.pnpm/node_modules/.bin/supabase. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/node_modules/.pnpm/node_modules/supabase/bin/supabase'
231:  WARN  Failed to create bin at /home/runner/work/liam/liam/node_modules/.pnpm/[email protected]/node_modules/supabase/node_modules/.bin/supabase. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/node_modules/.pnpm/[email protected]/node_modules/supabase/bin/supabase'
232:  .../node_modules/supabase postinstall$ node scripts/postinstall.js
233:  .../node_modules/supabase postinstall: Downloading https://github.com/supabase/cli/releases/download/v2.22.13/supabase_2.22.13_checksums.txt
234:  .../node_modules/supabase postinstall: Downloading https://github.com/supabase/cli/releases/download/v2.22.13/supabase_linux_amd64.tar.gz
235:  .../node_modules/supabase postinstall: Checksum verified.
236:  .../node_modules/supabase postinstall: Installed Supabase CLI successfully
237:  .../node_modules/supabase postinstall: Done
238:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/packages/cli/dist-cli/bin/cli.js'
239:  devDependencies:
...

252:  │                                                                              │
253:  │   Ignored build scripts: @biomejs/biome, @bundled-es-modules/glob,           │
254:  │   @depot/cli, @prisma/client, @prisma/engines, @sentry/cli, core-js-pure,    │
255:  │   esbuild, onnxruntime-node, protobufjs, sharp, style-dictionary.            │
256:  │   Run "pnpm approve-builds" to pick which dependencies should be allowed     │
257:  │   to run scripts.                                                            │
258:  │                                                                              │
259:  ╰──────────────────────────────────────────────────────────────────────────────╯
260:  frontend/apps/docs postinstall$ fumadocs-mdx
261:  frontend/packages/jobs postinstall$ cp ../db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm
262:  frontend/packages/jobs postinstall: Done
263:  frontend/apps/docs postinstall: [MDX] types generated
264:  frontend/apps/docs postinstall: Done
265:  frontend/apps/app postinstall$ cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm
266:  frontend/apps/app postinstall: Done
267:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/@liam-hq/cli/dist-cli/bin/cli.js'
268:  Done in 17.5s using pnpm v10.10.0
...

270:  with:
271:  path: ~/.cache/ms-playwright
272:  key: playwright-Linux-47aa71b220c39d1e7a9fe8d93097259eb7f9109a8eb5b198b3000f7059fdb322
273:  restore-keys: playwright-Linux-
274:  
275:  enableCrossOsArchive: false
276:  fail-on-cache-miss: false
277:  lookup-only: false
278:  save-always: false
279:  env:
280:  CI: true
281:  URL: https://liam-ip6x7f8d9-liambx.vercel.app
282:  ENVIRONMENT: Preview – liam-app
283:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
284:  ##[endgroup]
285:  [warning]Event Validation Error: The event type deployment_status is not supported because it's not tied to a branch or tag ref.
286:  ##[group]Run pnpm exec playwright install --with-deps
...

1540:  |■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■        |  90% of 2.3 MiB
1541:  |■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■| 100% of 2.3 MiB
1542:  FFMPEG playwright build v1011 downloaded to /home/runner/.cache/ms-playwright/ffmpeg-1011
1543:  ##[group]Run pnpm exec playwright test --project="chromium"
1544:  �[36;1mpnpm exec playwright test --project="chromium"�[0m
1545:  shell: /usr/bin/bash -e {0}
1546:  env:
1547:  CI: true
1548:  URL: https://liam-ip6x7f8d9-liambx.vercel.app
1549:  ENVIRONMENT: Preview – liam-app
1550:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
1551:  ##[endgroup]
1552:  Running 17 tests using 1 worker
1553:  ················×××××F
1554:  1) [chromium] › tests/vrt/vrt.test.ts:24:5 › top ─────────────────────────────────────────────────
1555:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
1556:  565 pixels (ratio 0.01 of all image pixels) are different.
...

1578:  |                      ^
1579:  12 | }
1580:  13 |
1581:  14 | interface TargetPage {
1582:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
1583:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
1584:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
1585:  tests/vrt/vrt.test.ts-snapshots/top-1-chromium-linux.png
1586:  ────────────────────────────────────────────────────────────────────────────────────────────────
1587:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
1588:  test-results/vrt-vrt-top-chromium/top-1-actual.png
1589:  ────────────────────────────────────────────────────────────────────────────────────────────────
1590:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
1591:  test-results/vrt-vrt-top-chromium/top-1-diff.png
1592:  ────────────────────────────────────────────────────────────────────────────────────────────────
1593:  Error Context: test-results/vrt-vrt-top-chromium/error-context.md
1594:  Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
1595:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
1596:  565 pixels (ratio 0.01 of all image pixels) are different.
...

1618:  |                      ^
1619:  12 | }
1620:  13 |
1621:  14 | interface TargetPage {
1622:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
1623:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
1624:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
1625:  tests/vrt/vrt.test.ts-snapshots/top-1-chromium-linux.png
1626:  ────────────────────────────────────────────────────────────────────────────────────────────────
1627:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
1628:  test-results/vrt-vrt-top-chromium-retry1/top-1-actual.png
1629:  ────────────────────────────────────────────────────────────────────────────────────────────────
1630:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
1631:  test-results/vrt-vrt-top-chromium-retry1/top-1-diff.png
1632:  ────────────────────────────────────────────────────────────────────────────────────────────────
1633:  Error Context: test-results/vrt-vrt-top-chromium-retry1/error-context.md
1634:  attachment #5: trace (application/zip) ─────────────────────────────────────────────────────────
1635:  test-results/vrt-vrt-top-chromium-retry1/trace.zip
1636:  Usage:
1637:  pnpm exec playwright show-trace test-results/vrt-vrt-top-chromium-retry1/trace.zip
1638:  ────────────────────────────────────────────────────────────────────────────────────────────────
1639:  Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
1640:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
1641:  619 pixels (ratio 0.01 of all image pixels) are different.
...

1663:  |                      ^
1664:  12 | }
1665:  13 |
1666:  14 | interface TargetPage {
1667:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
1668:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
1669:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
1670:  tests/vrt/vrt.test.ts-snapshots/top-1-chromium-linux.png
1671:  ────────────────────────────────────────────────────────────────────────────────────────────────
1672:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
1673:  test-results/vrt-vrt-top-chromium-retry2/top-1-actual.png
1674:  ────────────────────────────────────────────────────────────────────────────────────────────────
1675:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
1676:  test-results/vrt-vrt-top-chromium-retry2/top-1-diff.png
1677:  ────────────────────────────────────────────────────────────────────────────────────────────────
1678:  Error Context: test-results/vrt-vrt-top-chromium-retry2/error-context.md
1679:  Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
1680:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
1681:  565 pixels (ratio 0.01 of all image pixels) are different.
...

1703:  |                      ^
1704:  12 | }
1705:  13 |
1706:  14 | interface TargetPage {
1707:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
1708:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
1709:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
1710:  tests/vrt/vrt.test.ts-snapshots/top-1-chromium-linux.png
1711:  ────────────────────────────────────────────────────────────────────────────────────────────────
1712:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
1713:  test-results/vrt-vrt-top-chromium-retry3/top-1-actual.png
1714:  ────────────────────────────────────────────────────────────────────────────────────────────────
1715:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
1716:  test-results/vrt-vrt-top-chromium-retry3/top-1-diff.png
1717:  ────────────────────────────────────────────────────────────────────────────────────────────────
1718:  Error Context: test-results/vrt-vrt-top-chromium-retry3/error-context.md
1719:  Retry #4 ───────────────────────────────────────────────────────────────────────────────────────
1720:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
1721:  619 pixels (ratio 0.01 of all image pixels) are different.
...

1743:  |                      ^
1744:  12 | }
1745:  13 |
1746:  14 | interface TargetPage {
1747:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
1748:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
1749:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
1750:  tests/vrt/vrt.test.ts-snapshots/top-1-chromium-linux.png
1751:  ────────────────────────────────────────────────────────────────────────────────────────────────
1752:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
1753:  test-results/vrt-vrt-top-chromium-retry4/top-1-actual.png
1754:  ────────────────────────────────────────────────────────────────────────────────────────────────
1755:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
1756:  test-results/vrt-vrt-top-chromium-retry4/top-1-diff.png
1757:  ────────────────────────────────────────────────────────────────────────────────────────────────
1758:  Error Context: test-results/vrt-vrt-top-chromium-retry4/error-context.md
1759:  Retry #5 ───────────────────────────────────────────────────────────────────────────────────────
1760:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
1761:  565 pixels (ratio 0.01 of all image pixels) are different.
...

1783:  |                      ^
1784:  12 | }
1785:  13 |
1786:  14 | interface TargetPage {
1787:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
1788:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
1789:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
1790:  tests/vrt/vrt.test.ts-snapshots/top-1-chromium-linux.png
1791:  ────────────────────────────────────────────────────────────────────────────────────────────────
1792:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
1793:  test-results/vrt-vrt-top-chromium-retry5/top-1-actual.png
1794:  ────────────────────────────────────────────────────────────────────────────────────────────────
1795:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
1796:  test-results/vrt-vrt-top-chromium-retry5/top-1-diff.png
1797:  ────────────────────────────────────────────────────────────────────────────────────────────────
1798:  Error Context: test-results/vrt-vrt-top-chromium-retry5/error-context.md
1799:  1 failed
1800:  [chromium] › tests/vrt/vrt.test.ts:24:5 › top ──────────────────────────────────────────────────
1801:  16 passed (1.5m)
1802:  ##[error]Process completed with exit code 1.
1803:  ##[group]Run actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant