Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidying things up. #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tidying things up. #97

wants to merge 1 commit into from

Conversation

EatonCiaran
Copy link

  • Fix inconsistent use of single and double quotes. Now favours double quotes.
  • Fix inconsistent space and tab indenting, and remove trailing whitespaces. Now 4 space indent.
  • Removed unneeded semicolons on function declarations and for loops
  • Fix some typos, clarify some comments/messages, more consistent casing
  • Fix invalid HTML (lack of title element) and made it HTML 5.
  • Rename license file to standard convention
  • Remove custom equalTo function and instead use deepEqual for better error messages when type mismatch.
  • Make answer prompts more consistent i.e. some hinted for a string, only 1 really needs that
  • Flesh out README
  • Other general Prettier changes e.g. typeof not needing brackets; add trailing commas to objects and arrays; spaces before brackets, after commas, and between operators.

@EatonCiaran
Tidying things up.
a658219 
* Fix inconsistent use of single and double quotes. Now favours double quotes.
* Fix inconsistent space and tab indenting, and remove trailing whitespace. Now 4 space indent.
* Removed unneeded semicolons on function declarations and for loops
* Fix some typos, clarify some comments/messages, more consistent casing
* Fix invalid HTML (lack of title element) and made it HTML 5.
* Rename license file to standard convention
* Remove custom equalTo function and instead use deepEqual for better error messages when type mismatch.
* Make answer prompts more consistent i.e. some hinted for a string, only 1 really needs that
* Flesh out README
* Other general Prettier changes e.g. typeof not needing brackets; add trailing commas to objects and arrays; spaces before brackets, after commas, and between operators.
@EatonCiaran EatonCiaran mentioned this pull request Jul 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EatonCiaran