Pin dependencies to swiftlang GitHub organisation (was apple) and remove .git suffix #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamnichols
changed the title
liamnichols
force-pushed
the
ln/swiftlang-org
branch
from
91fad9d
to
1bf9d39
Compare
|
✅ Pull Request passed benchmark checks SummaryTue Jul 16 16:44:40 UTC 2024 New baseline 'pull_request' is WITHIN the 'main' baseline thresholds. Comparing results between 'main' and 'pull_request'XCStringsToolBenchmarksStringGenerator.generateSource(for:tableName:accessLevel:) metricsTime (total CPU): results within specified thresholds, fold down for details.
|
liamnichols
commented
Jul 16, 2024
Comment on lines
-35
to
+36
| "revision" : "8ddd519780452729c6634ad6bd0d2595938e9ea3", | ||
| "version" : "1.16.1" | ||
| "revision" : "c097f955b4e724690f0fc8ffb7a6d4b881c9c4e3", | ||
| "version" : "1.17.2" |
There was a problem hiding this comment.
This causes Xcode 16 tests to fail because GitHub Actions don't use Beta 3 yet
We can either wait GitHub, or I can patch the workflow to use an earlier version in the meantime... Will look into it.
There was a problem hiding this comment.
It took GitHub 9 days after Beta 2 was released to update. It's been 8 days since Beta 3 was released, so I'll just wait and see this week.
liamnichols
force-pushed
the
ln/swiftlang-org
branch
2 times, most recently
from
a119a65
to
2d6069d
Compare
liamnichols
force-pushed
the
ln/swiftlang-org
branch
from
2d6069d
to
2f59725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-syntax and swift-docc-plugin have moved to the swiftlang org on GitHub, while the existing links work, it can start to cause warnings to popup when mixing and matching urls.
This change updates our dependency definitions to use the new org which is what will happen with all packages eventually.
I also drop the .git suffix from the urls since it is redundant.
As part of this change, the pinned version of swift-snapshot-testing has been updated from 1.16.1 to 1.17.2.