Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin nglview version to 3.0.8 #224

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jotelha
Copy link
Contributor

@jotelha jotelha commented Jan 16, 2024

resolve #222 for now

@jameskermode
Copy link
Member

Thanks for figuring this out, will merge pending test pases (including the new docs checks in CI, thanks for adding that)

@jameskermode
Copy link
Member

Docs built successfully but I don't see where to check the HTML output: is it expected to have overwritten https://libatoms.github.io/matscipy/ from a PR, or will that only happen after we merge to master? I saw some discussion about making docs builds available from PRs, but maybe that hasn't been actioned yet?

@jameskermode
Copy link
Member

OK, that was in #214, guess this hasn't been done yet. Will go ahead and merge this then.

@jameskermode
Copy link
Member

The failing tests have now been set as xfail, going ahead with merge.

@jameskermode jameskermode merged commit 084bcab into libAtoms:master Jan 16, 2024
18 of 19 checks passed
@jotelha
Copy link
Contributor Author

jotelha commented Jan 16, 2024

OK, that was in #214, guess this hasn't been done yet. Will go ahead and merge this then.

Right, this so far should just fix the broken widgets, for docs preview I'll open another less urgent pull request.

@jameskermode
Copy link
Member

The live docs build is indeed fixed - many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive visualisation of atomic structures in documentation is broken
2 participants