Get SDL backend working on OSX #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also try to get travis building SDL on osx in this PR, or a new one? |
|
Thanks. We need CI for SDL on every system at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1335
This patch unsets
ALLEGRO_MACOSXif the SDL backend is requested. Some conditions controlling GL header inclusion had to be changed to a direct platform__APPLE__check, and a fewMACOSXcmake checks had to change toALLEGRO_MACOSX.I'm able to build and run the
ex_drawexample with this change, with and without the SDL backend. Although with SDL you must disable the native dialog addon manually (-DWANT_NATIVE_DIALOG=off). Should that be done in the build by default iffALLEGRO_SDL?