Fix MAC_OS_X_VERSION_MIN_REQUIRED checks to use correct six-digit values #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MAC_OS_VERSION_* constants jumped from 1090 to 101000, so checks for >= 1100 were passing in older versions than they should. Since Nixpkgs builds against 10.12 by default (on x86_64), this was causing Allegro 5.2.10.0 to fail to build because it couldn't find `UniformTypeIdentifiers/UniformTypeIdentifiers.h`.
Rhys-T
added a commit
to Rhys-T/nur-packages
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MAC_OS_VERSION_* constants jumped from 1090 to 101000, so checks for >= 1100 were passing in older versions than they should. Since Nixpkgs builds against 10.12 by default (on x86_64), this was causing Allegro 5.2.10.0 to fail to build because it couldn't find
UniformTypeIdentifiers/UniformTypeIdentifiers.h.