Bugfix for the ChemKin parser #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it seems that the bug was not the code, but my reading of ChemKin input files... We actually already had a test for chemkin-read thermo, hopefully now, I have it all figured out. |
|
Could you squash those two commits, please? |
are given first Correct orders of coefficients in test for thermo in ChemKin input file
SylvainPlessis
force-pushed
the
chemkin_bugfix
branch
from
dcf20fc to
18b349f
Compare
|
Also, we should probably cherry-pick it into the release, it's a pretty bad bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bugfix related to issue #165, it fixes for me the H2 values, this is what @beanSnippet remarked. If you can verify before merging.