Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Examples Directory to Antioch #218

Closed
wants to merge 14 commits into from
Closed

Add Examples Directory to Antioch #218

wants to merge 14 commits into from

Conversation

nicholasmalaya
Copy link
Contributor

This partially hits Numero seis on the todo list,

6. Add examples directory and example programs for usage. Kinetics, thermo, transport.

I've added a directory, a makefile.AM, and a single example that builds and runs on my box. I would recommend we merge this guy, and then create a separate ticket that would populate the examples directories with representative cases of the kinetics, thermo and transport API access patterns. Wouldn't mind input from @roystgnr or @pbauman (or David Sondak, is he on github?) about what we might want to add in this case. Or we could look at Cantera and mimic the useful parts of those tests.

nicholasmalaya and others added 14 commits October 30, 2013 15:02
@nicholasmalaya
[antioch]: adding @nicholasmalaya to AUTHORS file
e3aa4a7 
Also, massaging my severe OCD with respect to email addresses lining up.
@nicholasmalaya
[antioch]: adding header only and transport models to changelog
6bff919
@nicholasmalaya
Merge remote-tracking branch 'upstream/master'
3487660 
Conflicts:
	CHANGES
@nicholasmalaya
fixed a change i didnt want
66c5850
@nicholasmalaya
fixing things
f70e518
@nicholasmalaya
adding examples to build pattern
dec73a5
@nicholasmalaya
adding makefile.am with representative example routine
d9a8d6d
@nicholasmalaya
changing makefile.am, still not building
02a573d
@nicholasmalaya
adding examples to autoconf.ac directive
62028ab
@nicholasmalaya
adding example
a6d008d
@nicholasmalaya
Merge branch 'examples_dir' of https://github.com/nicholasmalaya/antioch
bbc6ea9 
 into examples_dir

* 'examples_dir' of https://github.com/nicholasmalaya/antioch:
  adding example
@nicholasmalaya
fixing a mislabelled test
f654440
@nicholasmalaya
compiles successfully, had stale elements in makefile.AM
42a337a
@nicholasmalaya
stealing an example from tests, test will compile and run on my box
c3d7445
@variscarey
Copy link

Is the todo list somewhere on the github page or is this some internal
email?

Varis

On Wed, Jul 6, 2016 at 3:48 PM, Nicholas Malaya [email protected]
wrote:

This partially hits Numero seis on the todo list,

  1. Add examples directory and example programs for usage. Kinetics, thermo, transport.

I've added a directory, a makefile.AM, and a single example that builds
and runs on my box. I would recommend we merge this guy, and then create a
separate ticket that would populate the examples directories with
representative cases of the kinetics, thermo and transport API access
patterns. Wouldn't mind input from @roystgnr https://github.com/roystgnr
or @pbauman https://github.com/pbauman (or David Sondak, is he on
github?) about what we might want to add in this case. Or we could look at

Cantera and mimic the useful parts of those tests.

You can view, comment on, or merge this pull request online at:

#218
Commit Summary

  • [antioch]: adding @nicholasmalaya to AUTHORS file
  • [antioch]: adding header only and transport models to changelog
  • Merge remote-tracking branch 'upstream/master'
  • fixed a change i didnt want
  • fixing things
  • adding examples to build pattern
  • adding makefile.am with representative example routine
  • changing makefile.am, still not building
  • adding examples to autoconf.ac directive
  • adding example
  • Merge branch 'examples_dir' of
    https://github.com/nicholasmalaya/antioch into examples_dir
  • fixing a mislabelled test
  • compiles successfully, had stale elements in makefile.AM
  • stealing an example from tests, test will compile and run on my box

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#218, or mute the thread
https://github.com/notifications/unsubscribe/AGfn2QxxYL9JDnjlPeuUDabloGRYWtt5ks5qTCKygaJpZM4JGidC
.

Varis Carey
Assistant Professor
Department of Mathematical and Statistical Sciences
University of Colorado Denver

@hovr2pi
Copy link

hovr2pi commented Jul 7, 2016

Paul is in town today and tomorrow and we were all huddled up and doing a hack a thon.

Here is the relevant antioch list from the email Paul sent around.

Antioch:

  1. More unit testing of �KineticsTheory� transport. As mentioned above, I was getting erroneous results with the Ozone flame with kinetics theory transport (IIRC, this manifest as temperature going unstable near where the reaction was starting). Also compare against Cantera output.
  2. Move existing �standalone� unit tests to CppUnit-based tests.
  3. Split out vibrational and electronic input into their own input files (for ASCII format).
  4. Add vibrational/electronic species data parsing to XML format. Make sure there�s no cross-compatibility issues with Cantera.
  5. Abandon parsing species molar mass and use elemental molar masses to sum up into species molar mass. This is what Cantera does and what we should be doing to more easily enable more complex species.
  6. Add examples directory and example programs for usage. Kinetics, thermo, transport.
  7. Add github.io website for Antioch and publish Doxygen documentation.
  8. Get CI testing going on UB servers if Civet is open-sourced between now and then.
  9. Populate more Blottner data based on fits to data (either the data roystgnr used the other day or, if we have confidence in our KineticsTheory implementation, use that).

On Jul 6, 2016, at 7:09 PM, Varis Carey [email protected] wrote:

Is the todo list somewhere on the github page or is this some internal
email?

Varis

On Wed, Jul 6, 2016 at 3:48 PM, Nicholas Malaya [email protected]
wrote:

This partially hits Numero seis on the todo list,

  1. Add examples directory and example programs for usage. Kinetics, thermo, transport.

I've added a directory, a makefile.AM, and a single example that builds
and runs on my box. I would recommend we merge this guy, and then create a
separate ticket that would populate the examples directories with
representative cases of the kinetics, thermo and transport API access
patterns. Wouldn't mind input from @roystgnr https://github.com/roystgnr
or @pbauman https://github.com/pbauman (or David Sondak, is he on
github?) about what we might want to add in this case. Or we could look at

Cantera and mimic the useful parts of those tests.

You can view, comment on, or merge this pull request online at:

#218
Commit Summary

  • [antioch]: adding @nicholasmalaya to AUTHORS file
  • [antioch]: adding header only and transport models to changelog
  • Merge remote-tracking branch 'upstream/master'
  • fixed a change i didnt want
  • fixing things
  • adding examples to build pattern
  • adding makefile.am with representative example routine
  • changing makefile.am, still not building
  • adding examples to autoconf.ac directive
  • adding example
  • Merge branch 'examples_dir' of
    https://github.com/nicholasmalaya/antioch into examples_dir
  • fixing a mislabelled test
  • compiles successfully, had stale elements in makefile.AM
  • stealing an example from tests, test will compile and run on my box

File Changes

Patch Links:

�
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#218, or mute the thread
https://github.com/notifications/unsubscribe/AGfn2QxxYL9JDnjlPeuUDabloGRYWtt5ks5qTCKygaJpZM4JGidC
.

Varis Carey
Assistant Professor
Department of Mathematical and Statistical Sciences
University of Colorado Denver
�
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dmcdougall
Copy link
Contributor

Added todo list here.

@dmcdougall
Copy link
Contributor

Clean history incoming. Don't merge this.

@dmcdougall dmcdougall mentioned this pull request Jul 7, 2016
Merged
@dmcdougall
Copy link
Contributor

Replaced by #225.

@dmcdougall dmcdougall closed this Jul 7, 2016
@roystgnr roystgnr mentioned this pull request Jul 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicholasmalaya @variscarey @hovr2pi @dmcdougall