Revert iterator referenced key_ member.

libbitcoin · Jun 11, 2024 · 069301c · 069301c
1 parent dcef21c
commit 069301c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/include/bitcoin/database/impl/query/archive.ipp b/include/bitcoin/database/impl/query/archive.ipp
@@ -86,10 +86,8 @@ inline bool CLASS::is_malleated64(const block& block) const NOEXCEPT
     if (!block.is_malleable64())
         return false;
 
-    // Pass l-value to iterator.
     // block.get_hash() assumes cached or is not thread safe.
-    const auto link = to_header(block.get_hash());
-    auto it = store_.txs.it(link);
+    auto it = store_.txs.it(to_header(block.get_hash()));
     if (!it)
         return false;
 

diff --git a/include/bitcoin/database/primitives/iterator.hpp b/include/bitcoin/database/primitives/iterator.hpp
@@ -76,7 +76,7 @@ class iterator
     const memory_ptr memory_;
 
     // This is thread safe.
-    const Key& key_;
+    const Key key_;
 
     // This is not thread safe.
     Link link_;